penningrothmatt / gimp-normalmap

Automatically exported from code.google.com/p/gimp-normalmap
Other
0 stars 0 forks source link

preview3d.c:595: warning: format not a string literal and no format arguments #8

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Running make with GCC 4.2 (probably more)

Compiled on OS X Snow Leopard with gcc-4.2.1 and dependencies installed via 
MacPorts.  GCC provided by Xcode 3.2.5.

To fix, I made the following changes:

Index: preview3d.c
===================================================================
--- preview3d.c (revision 44)
+++ preview3d.c (working copy)
@@ -592,7 +592,7 @@
    err = glewInit();
    if(err != GLEW_OK)
    {
-      g_message((char*)glewGetErrorString(err));
+      g_message("%s", (char*)glewGetErrorString(err));
       _gl_error = 1;
    }

I've also attached this as a diff.  Just need to make sure the first arg is a 
string literal, as it says in the warning.

Original issue reported on code.google.com by clifton....@gmail.com on 10 Feb 2011 at 9:24

GoogleCodeExporter commented 8 years ago
And here's the file I meant to attach.

Original comment by clifton....@gmail.com on 10 Feb 2011 at 9:26

Attachments:

GoogleCodeExporter commented 8 years ago
Fixed in release 1.2.3.

Original comment by ski...@gmail.com on 23 Jun 2012 at 3:07