Rewrite studyspaces to use LibCal API

pennlabs / penn-sdk-python

A Python module for the various services of Penn OpenData. Validated API token required.

MIT License

30 stars 5 forks source link

Rewrite studyspaces to use LibCal API #99

Closed ezwang closed 6 years ago

ezwang commented 6 years ago

Rewrite studyspaces to use LibCal API.

The arguments for booking are different in order to better match the LibCal API (building is no longer an argument, and there is a custom argument for various miscellaneous fields).
The rooms endpoint now returns rooms grouped by category.
Two additional environment variables need to be set after this change, LIBCAL_ID and LIBCAL_SECRET.

Should be tagged as 1.6.9 after merge.

Fixes #95.

esqu1 commented 6 years ago

Just make the above comment, otherwise LGTM

ezwang commented 6 years ago

The retry didn't actually help as much as I hoped, removed. Was intended to compensate for the large number of 500s returned by the Penn OpenData servers.