first_imageutils_commit

pennpolygons / cv-boilerplate

Open-source boilerplate for computer vision research

MIT License

16 stars 2 forks source link

first_imageutils_commit #14

Closed mchiquier closed 4 years ago

mchiquier commented 4 years ago

Here are the first set of functions I implemented. Its not yet typed but its mostly documented. This is just so you get an idea of what I'm doing.

goodmattg commented 4 years ago

I don't think it would be much work to add typing

goodmattg commented 4 years ago

This is good, but I see a few issues. Also, for reference when you see "[nit]" at the beginning of a comment, that is a nitpick. You can choose whether or not to listen to nitpicks at your discretion.

In my opinion this MR is missing:

Typing
Black Formatting (https://www.mattlayman.com/blog/2018/python-code-black/)
Minor style changes to numpy / PyTorch code

mchiquier commented 4 years ago

Ok please review now -- I have the unit tests left to do but wanted to do it properly with time today. Will work on it now.