Open jasonwalsh opened 7 years ago
Your issue doesn't follow our guidelines. Please fix the following:
Click here for details.
Thank you! :pray: This comment was made by GitMagic – Magically enforcing your contribution guidelines.
Your issue doesn't follow our guidelines. Please fix the following:
Click here for details.
Thank you! :pray: This comment was made by GitMagic – Magically enforcing your contribution guidelines.
Thank you, everything looks good now! :bowtie:
Hey i can help with this, can you tell me what should be the output ?
For example , i should be able to do : aptos convert -format protobuf example-schema.json
and aptos should output .proto defination file for the given schema ? is this requirement correct ?
Hey @subhajeet2107, thank you for your interest in contributing! Yes, your command: aptos convert -format protobuf example-schema.json
is correct.
Something like:
{
"title": "Person",
"type": "object",
"properties": {
"firstName": {
"type": "string"
}
},
"required": [ "firstName" ]
}
Would yield the following .proto
file:
message Person {
required string firstName = 1;
}
That's a really basic example, but I think starting with the primitive types, (e.g. string
, integer
, number
, boolean
, etc.) would be the easiest and then we can focus on the more complex types like array
(s), object
(s), enumeration
(s), etc.
Hi @rightlag are you open to using a template engine like Jinja2 for this?
Hi @malrusha, that's a great idea! I'm fine with using a template system like Jinja2.
Hi, what would be the latest expected release date for protocol buffer support ?
Hi @blaisezzz, I'd like to have support for protocol buffers by mid to late October.
I've created a new branch feature/protobuf to track all changes. I'll be updating shortly.
@jasonwalsh since this thread has been inactive for quite a while, can I work on this ?
Hi @ajainuary
Thank you for your interest in the project! Sure, that would be great! 👍
Feel free to submit a PR.
can I take this up?
@Nayan-Das Sure!
Ok..I am working on it.
It looks like this is still open. Any change in the requirement?
Currently,
aptos
supports converting JSON Schema documents into the Apache Avro data-interchange format.A proposed class in the
visitor
module (e.gProtobufSchemaVisitor
) should yield the converted Protocol Buffers document.