search

penny-university / penny_university

5 stars 6 forks source link

/penny chat in a private channel works but sends failure message #370

Closed JnBrymn closed 3 years ago

JnBrymn commented 3 years ago

Steps to Repro

In private channel type /penny chat and see:

image

but also see the modal pop up.

This might be confusing to users and lead them to mistrust the product is going to work.

ghost commented 3 years ago

The only way I see around this is giving Penny "god access" to every channel in the organization, since I don't think you can customize when users can see Slack's errors (unless it only says it failed because Penny doesn't send back a response, but it should send back something I think :thinking:). But, as said before in the weekly call, I'm not sure many other Slack workspaces will enjoy a bot having that much access.

mrshwah commented 3 years ago

This might not actually be a permissions issue. A few clues: https://stackoverflow.com/questions/63665120/slash-command-dispatch-failed

This is apparently a common issue https://github.com/slackapi/bolt-js/issues/579. That might be an issue with that particular framework, however.

mrshwah commented 3 years ago

And this Stack Overflow answer indicates that it will not send the correct channel if you make a command in a private channel. Maybe we are trying to use the channel id somewhere and it is failing.

mrshwah commented 3 years ago

Hah! Found the issue via Sentry and solved it by typing literally 2 characters 😂 .

Actually, I'll have to type a few more to solve it better.