search

penny-university / penny_university

5 stars 6 forks source link

Create matchmaker algorithm #377

Closed JnBrymn closed 3 years ago

JnBrymn commented 3 years ago

what

This is the matchmaker algorithm. The class doc explains how everything works.

why

Because we wanted a way to automatically match people together without having to do it manually. If our scoring function is "correct" then this approach will provably find the optimal pairing of people.

This is currently not connected to anything. I'll connect it next when I start automating the matching.

related

closes https://github.com/penny-university/penny_university/issues/374

JnBrymn commented 3 years ago

Thanks for the through read-through @deadbender. As a point of etiquette, please be sparing with the change requests. I typically reserve them for situations where a bug is about to be released into production or for a design decision is made that could damage the codebase in the future (even if it isn't explicitly a bug). If I don't think a PR is ready to ship, I'll "comment" about what is missing with the assumption that person working on the PR will take heed and ask me if they have any questions. And if I have just nit picks and recommendations, I'll make comments on the PR as recommendations and then accept the PR in order to allow them to ship the code when they think it's ready.

Do you feel that changes are still required before this PR can be shipped? (Remember, I'm planning to immediately use this code in subsequent PRs, so it'll change and become clearer as I make use of it.)

ghost commented 3 years ago

Sorry about that 😄 too used to how I do things over at work where a lot of my review focus goes towards design and making sure everything in one PR is ready to ship. Will keep that in mind going forward.

Don't think any changes are 100% necessary before this can be shipped. Switching over my review to a full approval now, good work here. This has been super interesting to follow.