Rather that meticulously fixing all the problems before testing our "will it survive outside" hypothesis, we aim to fix the obvious things that might cause problems and then just find the problems live as they occur.
Here are some likely sources of problems:
The user's identity is stored in two places, the User model and the SocialProfile model. The intent is that the User should have a 1:1 mapping with a person in real life regardless of how many slack teams they are members of. The SocialProfile is expected to represent a person's slack membership (or MS Teams membership in the future). A single User may have many SocialProfiles. Typically we contact people through information in their SocialProfiles so it is important that we don't confuse a member's many social profiles.
get_slack_client takes a slack team and returns the slack client associated with that team. Right now we're creating one slack client and then passing it around everywhere. This will make it possible to send messages to the wrong slack team (which will probably just error out).
There are two goals for this issue:
[ ] If you find some simple fixes, then fix them and list them here.
[ ] If you find something complicated, then make an issue in this epic.
Rather that meticulously fixing all the problems before testing our "will it survive outside" hypothesis, we aim to fix the obvious things that might cause problems and then just find the problems live as they occur.
Here are some likely sources of problems:
get_slack_clienttakes a slack team and returns the slack client associated with that team. Right now we're creating one slack client and then passing it around everywhere. This will make it possible to send messages to the wrong slack team (which will probably just error out).There are two goals for this issue: