Multi-version compatibility including 7.1

[quentindemetz]

Fork the directory tree by activerecord version and load the proper definition of the adapter based on the runtime version of ActiveRecord.

This includes the changes in https://github.com/pennylane-hq/activerecord7-redshift-adapter/pull/13

https://github.com/makandra/gemika seems to be a good way to implement basic testing for this

[quentindemetz]

Thanks for your feedback @owst

• I don't see any overhead in including largely duplicated code, since only the relevant version is required at runtime
• Testing is obviously still TBD but 🤞🏻 for https://github.com/makandra/gemika
• I'd rather not have to maintain x branches and backport fixes to all branches, and have everything live in one place. In the end it's the same result (many versions of the code are "live" and usable by users) and I find that having everything on the same branch is likely to be simpler operationally 🤞🏻

[quentindemetz]

Playing devil's advocate, but if we get activerecord-redshift-adapter it will break existing (legacy and non-updated) rails 3 apps which might rely on this gem. There's likely a bunch of these out there.

How about activerecord-adapter-redshift 😉 ?

[owst]

That's a good point - I wonder if a major version bump would be sufficient to sign post that the gem has significantly changed. Either way, it's moot unless rubygems would allow publishing a new gem under and old name - I somewhat doubt it.

I think it would be better to keep the activerecord-X-adapter naming convention along with the other popular gems:

So perhaps activerecord-redshift-X-adapter for some reasonable choice of X - new? modern? recent? ...?