pennylane-hq / activerecord-adapter-redshift

Other
6 stars 27 forks source link

column definitions are returning the wrong value for "null". #18

Closed jerryclinesmith closed 7 months ago

jerryclinesmith commented 7 months ago

In SchemaStatements (7.0 and 7.1), columns are returning with the wrong value for the null attribute.

Just need to change the line below, column_definitions are returning a boolean for the notnull field.

new_column(column_name, default_value, type_metadata, notnull == 'f', table_name, default_function)

to

new_column(column_name, default_value, type_metadata, !notnull, table_name, default_function)

Happy to submit a pull request, just let me know.