penpot / penpot-plugins

Repository for developing and running Penpot plugins with examples and libraries.
Mozilla Public License 2.0
27 stars 4 forks source link

Add 'allow-downloads' to iframe #150

Closed girafic closed 3 weeks ago

girafic commented 2 months ago

Add 'allow-downloads' to iframe. That will allows downloading files (generated images or zip files) through an a-tag with the download attribute.

cocotime commented 2 months ago

Hi @girafic!

Thanks for bringing this up! We do have the option to add 'allow-downloads' in our backlog, and we understand how important this functionality is for downloading files.

However, this feature won't be included in the current version as we are focusing on other priorities. However, it is planned for implementation in the following phase of development.

Thanks for your understanding and patience while we work on making the product better. Please feel free to reach out if you have any further questions or need help.

cocotime commented 1 month ago

Hi @girafic!

I hope you're having a great day!

We just wanted to give you a quick update on this issue. We're happy to say that we've finally been able to include the 'allow-downloads' option for this version. All you have to do is add the "allow:downloads" permission to your manifest.json file.

You can check the permission type here: https://penpot-docs-plugins.pages.dev/plugins/create-a-plugin/#types-of-permissions.

We've also included an example of how to download the penpot file in case you find this useful: https://github.com/penpot/penpot-plugins/blob/main/apps/poc-state-plugin/src/plugin.ts#L484. https://github.com/penpot/penpot-plugins/blob/main/apps/poc-state-plugin/src/app/app.component.ts#L293

Feel free to reach out if anything else comes up!

girafic commented 1 month ago

Hi @girafic!

I hope you're having a great day!

We just wanted to give you a quick update on this issue. We're happy to say that we've finally been able to include the 'allow-downloads' option for this version. All you have to do is add the "allow:downloads" permission to your manifest.json file.

You can check the permission type here: https://penpot-docs-plugins.pages.dev/plugins/create-a-plugin/#types-of-permissions.

We've also included an example of how to download the penpot file in case you find this useful: https://github.com/penpot/penpot-plugins/blob/main/apps/poc-state-plugin/src/plugin.ts#L484. https://github.com/penpot/penpot-plugins/blob/main/apps/poc-state-plugin/src/app/app.component.ts#L293

Feel free to reach out if anything else comes up!

@cocotime could I test that also on https://early.penpot.dev or only local at the momemt?

cocotime commented 1 month ago

Hi @girafic! I hope you're having a great day! We just wanted to give you a quick update on this issue. We're happy to say that we've finally been able to include the 'allow-downloads' option for this version. All you have to do is add the "allow:downloads" permission to your manifest.json file. You can check the permission type here: https://penpot-docs-plugins.pages.dev/plugins/create-a-plugin/#types-of-permissions. We've also included an example of how to download the penpot file in case you find this useful: https://github.com/penpot/penpot-plugins/blob/main/apps/poc-state-plugin/src/plugin.ts#L484. https://github.com/penpot/penpot-plugins/blob/main/apps/poc-state-plugin/src/app/app.component.ts#L293 Feel free to reach out if anything else comes up!

@cocotime could I test that also on https://early.penpot.dev or only local at the momemt?

Hi there! At the moment, we can't test it in the early environment, only in local. But, we'll be deploying it in https://early.penpot.dev/ in the next few days. We'll let you know as soon as it's ready.

cocotime commented 1 month ago

Hi! Just wanted to let you know that the latest changes are now available in https://early.penpot.dev/. Have a great day!