Closed ethitter closed 10 months ago
@ethitter Do we want to compile the files after the version bumps?
@eboniebutler That's an excellent question; I'm torn. This PR is already going to be gigantic, but we also need to know that all of the packages still work.
A compromise is to test each package's build locally and fix any incompatibilities in the build scripts themselves, but wait to commit new built files until after this PR is merged. Once merged, we can create another PR that encompasses all of the rebuilds. That approach will make the version history a bit less chaotic, and allows us to roll back the builds independently of the Node upgrades should we discover some catastrophic regression.
Thoughts?
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Deploy preview for pmc-larva ready!
✅ Preview https://pmc-larva-cykxop8zm-penske-media-corp.vercel.app
Built with commit 3ab91873d7b673a5137b8249c2489007ce11a1bd. This pull request is being automatically deployed with vercel-action
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.
Make sure you complete these items:
Unpublished
sectionnpm run prod
in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)prod
,lint
, anddev
scripts run as expected