Closed shawncook closed 5 months ago
Deploy preview for pmc-larva ready!
✅ Preview https://pmc-larva-1nzfa33tq-penske-media-corp.vercel.app
Built with commit 9086f3f353ee9a8cc8ea58bd11d281d0c3dcaf5e. This pull request is being automatically deployed with vercel-action
We noticed on Variety refresh that two of the social icons provided by Larva (Pinterest & Tumblr) are sized strangely compared to other social icons.
It appears that something during the image build process taps into an svg's
viewBox
attribute, which wasn't set for these two icons.To solve the issue, I've brought over the same icons from Nova in order to bring them into alignment.
By making the
viewBox
attribute available, built SVG icons should no longer build with aNaN
size.Make sure you complete these items:
Unpublished
sectionnpm run prod
in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)prod
,lint
, anddev
scripts run as expected