penske-media-corp / pmc-larva

PMC's design system.
pmc-larva-git-master-penske-media-corp.vercel.app
MIT License
19 stars 14 forks source link

PMCP-6256: Fix Pinterest and Tumblr icons in Larva #841

Closed shawncook closed 5 months ago

shawncook commented 5 months ago

We noticed on Variety refresh that two of the social icons provided by Larva (Pinterest & Tumblr) are sized strangely compared to other social icons.

It appears that something during the image build process taps into an svg's viewBox attribute, which wasn't set for these two icons.

To solve the issue, I've brought over the same icons from Nova in order to bring them into alignment.

By making the viewBox attribute available, built SVG icons should no longer build with a NaN size.

Make sure you complete these items:

github-actions[bot] commented 5 months ago

Deploy preview for pmc-larva ready!

✅ Preview https://pmc-larva-1nzfa33tq-penske-media-corp.vercel.app

Built with commit 9086f3f353ee9a8cc8ea58bd11d281d0c3dcaf5e. This pull request is being automatically deployed with vercel-action