Bugfix: Swap `plus` icon with Nova's for correct `viewbox`

penske-media-corp / pmc-larva

PMC's design system.

pmc-larva-git-master-penske-media-corp.vercel.app

MIT License

19 stars 14 forks source link

Bugfix: Swap `plus` icon with Nova's for correct `viewbox` #847

Closed JordanPak closed 4 months ago

JordanPak commented 4 months ago

This PR brings over Nova's "plus" icon so there's a proper viewbox attribute. Without this, <path> sizing in the SVG is messed up and causes weird alignments－social share, for example:

Make sure you complete these items:

[x] Updated root CHANGELOG.md with summary of changes under Unpublished section
[x] npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)

github-actions[bot] commented 4 months ago

Deploy preview for pmc-larva ready!

✅ Preview https://pmc-larva-6owxzmk3y-penske-media-corp.vercel.app

Built with commit 7d6fd5c514e62cf517e5397fcda9b7bcf69d64a6. This pull request is being automatically deployed with vercel-action