search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.36k stars 67 forks source link

Fix style glitch in campaign settings #117

Closed wmnnd closed 2 years ago

wmnnd commented 2 years ago

If the sender name is particularly long, this breaks the layout of the campaign settings modal.

ExplorerKut commented 2 years ago

hello @wmnnd by layout breaking do you mean something like this. image

wmnnd commented 2 years ago

@ExplorerKut Oh wow, that actually looks kind of neat :joy:

What I meant is that in the campaign settings modal you can’t see the buttons anymore if the Sender name + email is too long. I think this could be easily fixed by applying w-full to the select element: Screenshot 2022-02-28 at 05-23-10 Open Source Newsletter Tool · Keila

Edit: This is the template file with the modal: lib/keila_web/templates/campaign/_settings_dialog.html.heex

ExplorerKut commented 2 years ago

Hey, created a Pull Request for the above issue, I am a beginner so don't know much about how to create a good PR but tried my best. https://github.com/pentacent/keila/pull/118/commits/6247b25dc718f88c7fdaa00c11f8c7c13fbba103

ExplorerKut commented 2 years ago

Updated the PR. https://github.com/pentacent/keila/pull/118/commits/84745e4792c76641aa04d0a525e7f6a6167c30cf

ExplorerKut commented 2 years ago

Will look through other issues as well, see if I can help.