search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.36k stars 67 forks source link

added fix for style glitch in campaign settings Fixes #117 #118

Closed ExplorerKut closed 2 years ago

ExplorerKut commented 2 years ago

Fix for style glitch in campaign settings Changed the files in : lib/keila_web/templates/campaign/_settings_dialog.html.heex and added sm:w-full class to the select element at line 45. Before:

image

After:

image

wmnnd commented 2 years ago

Awesome, thanks for giving it a shot! :heart:

I think the sm: prefix is not needed for the class - because with it, the issue is only fixed on screens wider than 640px. So if you could change that, I’ll merge your PR.

ExplorerKut commented 2 years ago

okay, I will change that.

ExplorerKut commented 2 years ago

also while going through different display sizes in devtools, I am encountering something like this, Is this something to be worried of? image

wmnnd commented 2 years ago

also while going through different display sizes in devtools, I am encountering something like this, Is this something to be worried of?

You mean that the options are wider than the modal once you click on the select element? I wouldn’t worry about it because the Browser should take care that the options are displayed correctly.

ExplorerKut commented 2 years ago

updated the PR, removed the sm prefix.

wmnnd commented 2 years ago

Excellent, thank you!