search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.38k stars 70 forks source link

Add postmark #178

Closed aej closed 1 year ago

aej commented 1 year ago

Resolves https://github.com/pentacent/keila/issues/176

wmnnd commented 1 year ago

Thank you for contributing to Keila :partying_face:

aej commented 1 year ago

I've just deployed my own instance of Keila and tried out the new Postmark integration end-to-end. I can confirm it all worked as expected 🎉

wmnnd commented 1 year ago

Awesome, thanks for sharing! By the way, if you are serious about using Postmark, you might want to consider adding support for Postmark webhooks for bounces and spam complaints. You can see how I implemented this for SES here: https://github.com/pentacent/keila/blob/main/lib/keila_web/controllers/ses_webhook_controller.ex

aej commented 1 year ago

Awesome, thanks for sharing! By the way, if you are serious about using Postmark, you might want to consider adding support for Postmark webhooks for bounces and spam complaints. You can see how I implemented this for SES here: https://github.com/pentacent/keila/blob/main/lib/keila_web/controllers/ses_webhook_controller.ex

Ah yep - I built these out in my own app (which has its own separate Postmark integration) so I think I could add these pretty easily. Right now I dont have a need for webhook handling in Keila, but as soon as I do I'll add it in.