search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.38k stars 70 forks source link

Add a Block Editor based on Editor.js #179

Closed wmnnd closed 1 year ago

wmnnd commented 1 year ago

This is a WIP branch for implementing #175.

The Block editor will be added as an alternative to the existing Markdown and plain text editors.

keila-editorjs

wmnnd commented 1 year ago

It’s finally here! :partying_face:

@everyone: I would like to merge this PR next week, and would be very grateful for feedback before that - maybe there are still some bugs I haven’t yet managed to find :lady_beetle:

keila-block-editor

wmnnd commented 1 year ago

@panoramix360 & @gbottari As always, your feedback would be especially appreciated :blush:

panoramix360 commented 1 year ago

@panoramix360 & @gbottari As always, your feedback would be especially appreciated 😊

I'll look into it this weekend, sorry for not doing anything for these months!

wmnnd commented 1 year ago

I'll look into it this weekend, sorry for not doing anything for these months!

That would be fantastic! :hugs: Looking forward to hearing what you think of the new editor!

panoramix360 commented 1 year ago

I'm taking a look piece by piece, it's a very long PR haha

wmnnd commented 1 year ago

@panoramix360 What do you think, is the PR ready to be released? :sweat_smile:

panoramix360 commented 1 year ago

I made a lot of comments :)

They are just suggestions feel free to let me know what you think!

I never worked with Liquid template system so it's cool to take a look haha

I'm sorry for taking so long to review, I'll try to be better in my next responses.

It's nice to be back looking through Elixir code 😃

wmnnd commented 1 year ago

@panoramix360 Thank you for adding your comments, I think you’re making some very good points!

At this point I feel like I want to ship the new feature as soon as possible and then do some refactoring at the same time as users are already trying out the new experience. Have you been able to play around with the new features from a user side a bit and have you found any blockers (from a user perspective) there?

panoramix360 commented 1 year ago

@wmnnd no problem :D

I didn't have the time to play around as a user, I just looked through the code.

But you can merge the push and I'll look after it, if any bugs or things appear I'll create an issue then, what do you think?

wmnnd commented 1 year ago

But you can merge the push and I'll look after it, if any bugs or things appear I'll create an issue then, what do you think?

Sure, that would be great! Though I’m not gonna merge it before next week, because I’m currently at ElixirConf EU :smiley:

panoramix360 commented 1 year ago

But you can merge the push and I'll look after it, if any bugs or things appear I'll create an issue then, what do you think?

Sure, that would be great! Though I’m not gonna merge it before next week, because I’m currently at ElixirConf EU 😃

Oh nice!! :D

Are you showcasing the project there? How is it going?