websocket URL is not considering the URL_PATH.

pentacent / keila

Open Source Newsletter Tool.

https://keila.io

GNU Affero General Public License v3.0

1.26k stars 61 forks source link

websocket URL is not considering the URL_PATH. #189

Closed cinco closed 1 year ago

cinco commented 1 year ago

the websocket URL is not considering the URL_PATH.

In the console I get mydomain.com/live/websocket?_csrf_token=...., even though I have URL_PATH=/newsletter.

While you would expect the websocket at mydomain.com/newsletter/live/websocket?_csrf_token=....

URL_PATH was implemented from request feature #77

wmnnd commented 1 year ago

Thanks for reporting this. The problem comes from the fact that the socket path is hardcoded in app.js. I’ll fix it for the next release.

cinco commented 1 year ago

thanks @wmnnd

The projects link in the left menu is also ignoring URL_PATH.

Should I open another issue or can it be handled in this one?

wmnnd commented 1 year ago

I’ll also handle it in this issue.

wmnnd commented 1 year ago

This issue has been fixed in af6e37e00fad3e46991540ad5e88e8058b7da6d3. The fix will be released as part of the upcoming next version with the Block editor.

st3xupery commented 2 months ago

Forgive me, but was this issue fixed by the commit? I am running the docker image for keila 0.14.4 and I am still getting this exact same error when accessing the Campaign editor.

wmnnd commented 2 months ago

@st3xupery Did you set URL_HOST as well?

st3xupery commented 2 months ago

Yes, and most all of the assets are querying from the correct URL_HOST and URL_PATH, it only shows up for this websocket route (and a route for some fonts).