search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.25k stars 61 forks source link

add build support for arm64 #248

Closed moritz-topp closed 7 months ago

moritz-topp commented 7 months ago

Hey, I would like to use Keila on my ARM64 Server, to do that we need to change the build config, to also publish linux/arm64 images on the Docker Hub. Would be nice if you add it.

I just added one GitHub Action Config line, taken from: https://github.com/docker/setup-buildx-action?tab=readme-ov-file#inputs It just tells the docker/build-push-action to push for both platforms (amd6 and arm64).

wmnnd commented 7 months ago

Thank you for this suggestion! Have you tried if the image built like that actually works?

wmnnd commented 7 months ago

Hey @moritz-topp, I’m totally open to add arm64 support but I don’t have the time right now to test this myself. So if you could give it a try and confirm this change actually works, I’d be happy to merge your PR :slightly_smiling_face:

moritz-topp commented 7 months ago

Hey @wmnnd, I am sorry, I completely missed your first reply 😞 No problem, in the following days I am going to test if the changes are working and will get in touch with you again :)

moritz-topp commented 7 months ago

Hey, I tested around locally and in my repo. But I couldn't get it to work with ARM Architecture. The problem was to run the mix Command from Elixir, looked like it missed some libs. I am too unfamiliar with elixir to fix it.