search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.45k stars 81 forks source link

Internal Server when clicking "Delete selected contacts" without having contacts selected. #260

Closed CSDUMMI closed 9 months ago

CSDUMMI commented 10 months ago

I was on the contacts page of a project and clicked the button "Delete selected" before selecting the contacts I wanted to remove. This lead to a text-only "Internal Server Error" page.

The controller of the delete action should probably check if any contacts are selected and fail gracefully and the UI could probably be changed to make the "Delete selected" button unclickable unless at least one contact was selected.

wmnnd commented 10 months ago

Thank you for reporting this, I can confirm this is a bug and I’ll fix it soon.

wmnnd commented 9 months ago

This has now been fixed, thanks for reporting this @CSDUMMI.