search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.36k stars 67 forks source link

Segment editor should correctly parse segments with custom data fields #92

Closed wmnnd closed 2 years ago

wmnnd commented 2 years ago

Currently, custom data fields can be added to a filter, but aren’t correctly converted back into form data after saving.

panoramix360 commented 2 years ago

Hi @wmnnd, me and @gbottari were looking into this issue just to see what needs to be done.

We already know that we need to implement a new variation of the function filter_condition_to_form_data to type "custom".

But we noticed after looking into code, that this issue is already "In Progress" on your Roadmap, do you need any help?

Maybe we can give it a shot if you didn't start the implementation yet.

wmnnd commented 2 years ago

I’ve already fixed it in my local branch, I need to push it one of these days :joy: