pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.36k stars 67 forks source link

Implement API #93

Closed wmnnd closed 2 years ago

wmnnd commented 2 years ago

Implementation of #75

wmnnd commented 2 years ago

This PR now includes APIs for managing Contacts, Campaigns, and Segments and I think it’s a good starting point. I would be very happy about some feedback @panoramix360 & @gbottari :smiley:

panoramix360 commented 2 years ago

I'll try to look into it tomorrow :D

panoramix360 commented 2 years ago

The purpose of this PR is to enable Keila to be integrated with other backends, right? Really nice :D

Some ideas or thoughts in general:

I wrote some comments on your code, but sorry for putting too many haha :)

Feel free to let me know what do you think \o

wmnnd commented 2 years ago

Those are some very good points! I think I’ll try refactoring the code a bit, including special Schema modules and something to create OpenAPI schemas.

wmnnd commented 2 years ago

Updated PR with OpenAPI will hopefully be done tomorrow :partying_face: Screenshot 2021-12-27 at 20-05-54 Swagger UI

wmnnd commented 2 years ago

Thanks so much for your valuable feedback, @panoramix360! I have now done an extensive refactoring of the API controllers, making them much more modular, and adding Open API specs :partying_face:

panoramix360 commented 2 years ago

I'm glad that it helped :D

I'll look for your modifications on this week :tada: