search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.36k stars 67 forks source link

Add DevContainer support #95

Closed panoramix360 closed 2 years ago

panoramix360 commented 2 years ago

I noticed that the project has a Dockerfile and docker-compose.yml, and was wondering if you guys know DevContainer from Microsoft?

Is a tool to Visual Code that lets you develop inside a container, it's pretty neat.

To build/develop the project on my machine when contributing in the last PR I configured a devcontainer.json on the project to run it inside a container, it uses docker-compose by default.

Do you think that it'll be nice to have this configuration on the project? I can open a PR for this.

Thank you! :smiley:

wmnnd commented 2 years ago

I think that’s a neat idea to make developing Keila even easier! Feel free to create a PR, including a note in README.md.

I would just want to make sure it’s clear that this is an optional way of developing the project and not required :+1:

panoramix360 commented 2 years ago

Glad that you liked it!

I agree with you about this being optional.

I'll create the PR and change the README to include how to configure this :tada:

wmnnd commented 2 years ago

This was implemented in #99 and is now part of the 0.9.0 release :partying_face: