pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.36k stars 67 forks source link

Adding DevContainer support #99

Closed panoramix360 closed 2 years ago

panoramix360 commented 2 years ago

As promised on issue #95, we added support for DevContainer from Microsoft on Visual Code.

We added some steps on README to help others running the project and marked as optional.

wmnnd commented 2 years ago

Very cool, thanks for building this! :clap:

I just gave it a try and I have a few thoughts:

panoramix360 commented 2 years ago

Nice points @wmnnd, thank you for letting me know.

I'll look into it to discover why npm install was not runned and the other points about the docker-compose version and Alpine.

I'll let you know my conclusions :)

panoramix360 commented 2 years ago

Hi @wmnnd, sorry for the delay in this change.

We are getting back from the holidays and will return our contributions here :D

wmnnd commented 2 years ago

No worries, I’m very happy you’re still motivated to help :partying_face:

panoramix360 commented 2 years ago

@wmnnd we updated with what you suggested!

We included mix deps.get command on the postCreateCommand too, so after running devcontainer for the first time, the developer will only need to run mix phx.server :D

Please, let me known what you think

wmnnd commented 2 years ago

Looking great, thanks for this contribution, it’ll make it super easy for new people who want to contribute :heart: