pentaho / pdi-sdk-plugins

PDI SDK plugins
111 stars 154 forks source link

[PPP-3735] - Use of vulnerable component httpclient-3.0.1.jar, common… #41

Closed YuryBY closed 7 years ago

YuryBY commented 7 years ago

…s-httpclient-3.1 - httpclient-4.0.1.jar, SONATYPE-2007-0004, CVE-2012-6153, CVE-2011-1498, CVE-2014-3577

@mbatchelor, @pamval, could you please take a look?

wingman-pentaho commented 7 years ago

Build Completed

:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -fn -f kettle-sdk-embedding-samples/pom.xml clean install && mvn -B -f kettle-sdk-embedding-samples/pom.xml site

Cleanup Commands

mvn -B -f kettle-sdk-embedding-samples/pom.xml build-helper:remove-project-artifact

Changed files

  kettle-sdk-embedding-samples/pom.xml
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/AbstractSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/AllocateServerSocketSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/CleanupTransSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/ExecuteTransSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/GetJobImageSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/GetJobStatusSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/GetSlavesSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/GetStatusSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/GetTransImageSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/GetTransStatusSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/ListServerSocketSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/NextSequenceSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/PauseTransSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/PrepareExecutionTransSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/RegisterJobSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/RegisterPackageSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/RegisterSlaveSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/RegisterTransSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/RemoveJobSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/RemoveTransSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/RunJobSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/RunTransSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/SniffStepSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/StartExecutionTransSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/StartJobSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/StartTransSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/StopJobSample.java
  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/carte/StopTransSample.java

Newly Fixed Tests:

org.pentaho.di.sdk.samples.carte.JobServletsTest.testJobServlets:

:large_blue_circle: org.junit.ComparisonFailure

org.junit.ComparisonFailure: expected:<[Finished]> but was:<[Running]>
    at org.pentaho.di.sdk.samples.carte.JobServletsTest.testJobServlets(JobServletsTest.java:124)

Unit test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

org.pentaho.di.sdk.samples.carte.GetJobStatusSample
org.pentaho.di.sdk.samples.carte.GetStatusSample
org.pentaho.di.sdk.samples.carte.RegisterJobSample
org.pentaho.di.sdk.samples.carte.StartJobSample
org.pentaho.di.sdk.samples.embedding.CapturingTransformationRows
org.pentaho.di.sdk.samples.embedding.CapturingTransformationRows.new RowAdapter() {...}
org.pentaho.di.sdk.samples.embedding.GeneratingJobs
org.pentaho.di.sdk.samples.embedding.GeneratingTransformations
org.pentaho.di.sdk.samples.embedding.RunningJobs
org.pentaho.di.sdk.samples.embedding.RunningTransformations
YuryBY commented 7 years ago

@mbatchelor, @pamval, could you please take a look?