search

pentaho / pdi-sdk-plugins

PDI SDK plugins
111 stars 154 forks source link

[PDI-16923] - a typo bug in kettle-sdk-embedding-samples #65

Closed cravobranco closed 6 years ago

cravobranco commented 6 years ago
cravobranco commented 6 years ago

@mchen-len-son, @duarteteixeira, @pentaho-lmartins, @mbatchelor please review. Thanks in advance!

wingman-pentaho commented 6 years ago

Build Completed

:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd site

Cleanup Commands

mvn -B -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/embedding/RunningTransformations.java

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/embedding/RunningTransformations.java. Found 2017. Was expecting 2018

wingman-pentaho commented 6 years ago

Build Completed

:white_check_mark: This pull request has passed all validations.

Build Commands

mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd site

Cleanup Commands

mvn -B -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/embedding/RunningTransformations.java
wingman-pentaho commented 6 years ago

Build Completed

:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd site

Cleanup Commands

mvn -B -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/embedding/RunningTransformations.java

Newly Fixed Tests:

org.pentaho.di.sdk.samples.carte.GetStatusSampleTest.testXMLResponse:

:large_blue_circle: org.apache.http.conn.HttpHostConnectException

org.apache.http.conn.HttpHostConnectException: Connect to localhost:36884 [localhost/127.0.0.1] failed: Connection refused (Connection refused)
    at org.pentaho.di.sdk.samples.carte.GetStatusSampleTest.testXMLResponse(GetStatusSampleTest.java:53)
Caused by: java.net.ConnectException: Connection refused (Connection refused)
    at org.pentaho.di.sdk.samples.carte.GetStatusSampleTest.testXMLResponse(GetStatusSampleTest.java:53)

Still Broken Tests:

org.pentaho.di.sdk.samples.carte.GetStatusSampleTest.testMain:

:red_circle: org.apache.http.conn.HttpHostConnectException

org.apache.http.conn.HttpHostConnectException: Connect to localhost:55817 [localhost/127.0.0.1] failed: Connection refused (Connection refused)
    at org.pentaho.di.sdk.samples.carte.GetStatusSampleTest.testMain(GetStatusSampleTest.java:81)
Caused by: java.net.ConnectException: Connection refused (Connection refused)
    at org.pentaho.di.sdk.samples.carte.GetStatusSampleTest.testMain(GetStatusSampleTest.java:81)
wingman-pentaho commented 6 years ago

Build Completed

:white_check_mark: This pull request has passed all validations.

Build Commands

mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd site

Cleanup Commands

mvn -B -f 'pom.xml' -pl 'kettle-sdk-embedding-samples' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  kettle-sdk-embedding-samples/src/main/java/org/pentaho/di/sdk/samples/embedding/RunningTransformations.java