[BACKLOG-40475] Browse Perspective: "Open" PVFS file actions

singletonc commented 5 months ago

PR Set:

SolutionBrowserPanel:

added spotbugs dependency so that we can use GenericFileNameUtils
in this effort we will be supporting the following extensions for PVFS file "Open" actions -- supportedGenericFileExtensions = Arrays.asList( "html", "pdf", "txt", "rtf", "xlsx" ); -- helper function to check if a fileName has an acceptable extension
created general error dialog function to support existing plugin missing error along with new unsupported file type/extension error -- made these functions accessible to other js files, along with isRepositoryPath
introduced logical fork to separate Repository vs PVFS file opening for now
introduced new generic-files/<path>/content endpoint for both Repository and PVFS files
fixed recents encoding to match the current front/backend encoding/decoding

browser.js and related files:

enabled "Open" and "Open in a new window" buttons for PVFS files, both single and multi-selected -- re-enabled double-click to open functionality, which also fixes BACKLOG-41004 -- disable and hide all other buttons for folder and file actions -- moved some repository-only logic under conditional to prevent re-showing of download and related buttons
included new logic to decode folder/file names and paths as some special characters are now coming through encoded from the back-end [BACKLOG-41089]
added conditional logic in index.jsp to check if the file extension for PVFS files is valid before opening the "Opened" perspective in case of double-click

buildguy commented 5 months ago

:white_check_mark: Build finished in 13m 54s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl user-console

:ok_hand: All tests passed!

Tests run: 12, Failures: 0, Skipped: 0 Test Results

:information_source: This is an automatic message

buildguy commented 5 months ago

:white_check_mark: Build finished in 7m 29s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl user-console

:ok_hand: All tests passed!

Tests run: 12, Failures: 0, Skipped: 0 Test Results

:information_source: This is an automatic message

buildguy commented 5 months ago

:white_check_mark: Build finished in 7m 2s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl user-console

:ok_hand: All tests passed!

Tests run: 12, Failures: 0, Skipped: 0 Test Results

:information_source: This is an automatic message

buildguy commented 5 months ago

:x: Build failed in 2m 1s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl user-console

:exclamation: No tests found!

Errors:

Filtered log (click to expand)

``` script returned exit code 1 ```

:information_source: This is an automatic message

buildguy commented 5 months ago

:white_check_mark: Build finished in 7m 35s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl user-console

:ok_hand: All tests passed!

Tests run: 12, Failures: 0, Skipped: 0 Test Results

:information_source: This is an automatic message

buildguy commented 5 months ago

:x: Build failed in 5m 5s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl user-console

:ok_hand: All tests passed!

Tests run: 12, Failures: 0, Skipped: 0 Test Results

Errors:

Filtered log (click to expand)

``` script returned exit code 1 ```

:information_source: This is an automatic message

buildguy commented 5 months ago

:white_check_mark: Build finished in 9m 42s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl user-console

:ok_hand: All tests passed!

Tests run: 12, Failures: 0, Skipped: 0 Test Results

:information_source: This is an automatic message

buildguy commented 5 months ago

:white_check_mark: Build finished in 7m 33s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl user-console

:ok_hand: All tests passed!

Tests run: 12, Failures: 0, Skipped: 0 Test Results

:information_source: This is an automatic message

buildguy commented 5 months ago

:white_check_mark: Build finished in 9m 53s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl user-console

:ok_hand: All tests passed!

Tests run: 12, Failures: 0, Skipped: 0 Test Results

:information_source: This is an automatic message

hitachivantarasonarqube[bot] commented 5 months ago

SonarQube Quality Gate

0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

buildguy commented 5 months ago

[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)

Note:

---

**Frogbot** also supports **Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning**. This features are included as part of the [JFrog Advanced Security](https://jfrog.com/advanced-security) package, which isn't enabled on your system.

[🐸 JFrog Frogbot](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)

buildguy commented 5 months ago

:white_check_mark: Build finished in 9m 22s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl user-console

:ok_hand: All tests passed!

Tests run: 12, Failures: 0, Skipped: 0 Test Results

:information_source: This is an automatic message

buildguy commented 5 months ago

:x: Build failed in 5s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox

:exclamation: No tests found!

Errors:

Filtered log (click to expand)

``` no protocol: repo.orl.eng.hitachivantara.com ```

:information_source: This is an automatic message

pentaho / pentaho-platform