pentaho / pentaho-platform

Pentaho BA Server Core
http://www.pentaho.com
Other
472 stars 723 forks source link

[CLEANUP] fixing failing test KarafBootTest#verifyStaleLockBehavior #5696

Closed NJtwentyone closed 2 months ago

NJtwentyone commented 2 months ago

suggested fix, set stale/unused pid to -1, since it is a valid PID for an invalid process for windows and *nix:

Backstory:

On my local M2 Chip Mac, I was having the unit test KarafBootTest#verifyStaleLockBehavior fail, the process id (pid) 0 was actually being used mac_pid_0_fails

mac_debugger_evaluate_pid_0_in_use

When I set it to really high number pid 999999... that isn't used, the test pass:

mac_pid_9999999_pass

When I set the pid to -1, the test pass:

mac_pid_-1_pass

hitachivantarasonarqube[bot] commented 2 months ago

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

buildguy commented 2 months ago
[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)

[🐸 JFrog Frogbot](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)