search

pentaho / pentaho-reporting

Java class library for generating reports.
Other
283 stars 364 forks source link

[SP-6340] Backport of PPP-4867 - org.pentaho.reporting.engine.classic.core.allowScriptEvaluation error shown when report DOES NOT use scriptable data sources (9.3 Suite) #1569

Closed MarcDiamantHitachi closed 1 year ago

MarcDiamantHitachi commented 1 year ago

Original PR: #1556

@bcostahitachivantara @renato-s @andreramos89

smmribeiro commented 1 year ago

@MarcDiamantHitachi there are some problems with this PR:

The commit message should state the SP issue. Normally, we'd use "[SP-6340] Backport of PPP-4867 - org.pentaho.reporting.engine.classic.core.allowScriptEvaluation error shown when report DOES NOT use scriptable data sources (9.3 Suite)"

The final code to merge is not completely consistent to the original code: one can see that there's extra lines on the copyright header immediately and GitHub calculates this PR as "+16 -5" while the original one (https://github.com/pentaho/pentaho-reporting/pull/1556) is "+7 -8"...

There are two commits on this PR: the "cherry pick" and a merge operation; I suspect that the merge operation is "breaking" something.

Could you, please, fix these issues?