[SP-6489] - Backport of BISERVER-14865 - Impossible to download PIR reports onto Excel 2007 format once data is past Excel limitations (9.3 Suite)

pentaho / pentaho-reporting

Java class library for generating reports.

GNU Lesser General Public License v2.1

277 stars 360 forks source link

[SP-6489] - Backport of BISERVER-14865 - Impossible to download PIR reports onto Excel 2007 format once data is past Excel limitations (9.3 Suite) #1634

Closed renato-s closed 4 months ago

renato-s commented 4 months ago

Original PR:

https://github.com/pentaho/pentaho-reporting/pull/1627

buildguy commented 4 months ago

:warning: Build finished in 18m 59s

Build command:

mvn clean verify -B -e -Daudit -amd -pl engine/core

:no_entry: Failed Tests

:cloud_with_lightning_and_rain: 1 test(s) failed:

org.pentaho.reporting.engine.classic.extensions.datasources.mondrian.EmptyCellsetTest.testEmptyResult (click to expand)

``` results should be empty, rowcount should be 0. expected:<0> but was:<1> ```

Tests run: 2279, Failures: 1, Skipped: 15 Test Results

:information_source: This is an automatic message

buildguy commented 4 months ago

[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)

Note:

---

**Frogbot** also supports **Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning**. This features are included as part of the [JFrog Advanced Security](https://jfrog.com/advanced-security) package, which isn't enabled on your system.

[🐸 JFrog Frogbot](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)

buildguy commented 4 months ago

:warning: Build finished in 21m 49s

Build command:

mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox -pl engine/core

:no_entry: Failed Tests

:cloud_with_lightning_and_rain: 1 test(s) failed:

org.pentaho.reporting.engine.classic.extensions.datasources.mondrian.EmptyCellsetTest.testEmptyResult (click to expand)

``` results should be empty, rowcount should be 0. expected:<0> but was:<1> ```

Tests run: 2279, Failures: 1, Skipped: 15 Test Results

:information_source: This is an automatic message

smmribeiro commented 4 months ago

Based on the fact that:

the unit test that is failing on Wingman (org.pentaho.reporting.engine.classic.extensions.datasources.mondrian.EmptyCellsetTest.testEmptyResult), is also failing on the 9.3.0.7 RC builds since the beginning (without this development)
this same development did not cause any failures on master

I'm approving and merging this PR.