search

pentarex / react-native-gallery-manager

30 stars 41 forks source link

requiresMainQueueSetup warning #9

Open rangav opened 6 years ago

rangav commented 6 years ago

Hi

Does it require main Queue or not? getting react native warning

+ (BOOL)requiresMainQueueSetup
{
    return YES;
}
pentarex commented 6 years ago

Hi @rangav ! When are you getting this warning?

rangav commented 6 years ago

When you build the RN proj in xcode, you will see warnings in output

OR when remote js dubug enabled we will see in chrome console

pentarex commented 6 years ago

https://github.com/facebook/react-native/pull/17679 I guess it should return NO, The Image loader that this library is using is rewritten from RCTImageLoader (because I wanted to remove the dependencies). And somehow makes sense to be NO, because we don't want to block the app while loading the images. Anyhow its warning and its by default in the background.

I will fix it today and upload a new version, anyhow I have to add request authorisation to android :)

rangav commented 6 years ago

Thanks @pentarex will change to NO and will do some testing.

pentarex commented 6 years ago

ok please let me know :)

rangav commented 6 years ago

returning NO is working.

+ (BOOL)requiresMainQueueSetup
{
    return NO;
}