pentix / qjournalctl

A multi-platform, Qt-based frontend for systemd's journalctl command. Accepting local as well as remote (SSH) data sources.

GNU General Public License v3.0

166 stars 17 forks source link

QJournalctl win32 x64 port. #41

Closed alacasta closed 4 years ago

alacasta commented 4 years ago

What?

This is a contribution which aims to port the QJournalctl application to Windows.

Details

The major contribution is

To provide an script and updated configuration to be able to build the application for Windows.
To add an appveyor configuration to be able to directly obtain the released artifacts from there (deployed artifacts)

There are some few changes applied to the codebase:
Migration of the usleep to a multi-platform equivalent call
Minor modification from iniializing an array of size a variable, which is not compliant with the msvc build rules. Migrated to safer malloc based initialization.

Also to the README.md

Unifying the type of Markdown Titles
Reordering the building chapter
Adding an specific Windows chapter

Remaining tasks

[ ] To update the Changelog in case of performing a releease with these changes
[ ] To integrate appveyor to the official repository.

pentix commented 4 years ago

As already stated in my previous email, I'd suggest some changes: :relieved:

[ ] Fixing the "Save SSH connections" function
[ ] Disabling all local systemd related functions for the Windows port
[ ] Copy the detailed setup instructions into the README
[ ] Prefix/Squash all "fix CI" commits together to keep the commit history somewhat structured
[ ] Maybe some cosmetic changes in the autogen_and_build.bat script