search

pentix / qjournalctl

A multi-platform, Qt-based frontend for systemd's journalctl command. Accepting local as well as remote (SSH) data sources.
GNU General Public License v3.0
166 stars 17 forks source link

Fix: Verify settings not null #53

Closed alacasta closed 4 years ago

alacasta commented 4 years ago

What?

Issue: https://github.com/pentix/qjournalctl/issues/52

When the ConnectionDialog::ConnectionDialog object is created from the following call

    ConnectionDialog dialog(nullptr, nullptr, sshConnectionSerializer, true);

The **settings object is null (and also *settings). Due to this fact, the application crashed when trying to assign an unainitialized value to nullptr.

The solution is based on basically verifying that the variable is initialized prior to setting it to nullptr