search

pentix / qjournalctl

A multi-platform, Qt-based frontend for systemd's journalctl command. Accepting local as well as remote (SSH) data sources.
GNU General Public License v3.0
166 stars 17 forks source link

Fix deb compatibility with Debian #78

Closed brenard closed 2 years ago

brenard commented 2 years ago

In Debian, the libssh package does not exist : it's named libssh-4. This PR just fix the dependency declared in control file.

Note: I try to build and install the resulting package on my Debian Stable and it's work great.

pentix commented 2 years ago

Hey there, thanks a lot for approaching me with this PR!

That makes perfect sense I guess, I will however need to make sure this does not break all Ubuntu-based distros or the build process for those platforms described in the README.

For now, it seems the name was already adopted into 18.04LTS (but still, their version is too old), so I don't really now why I sticked to this name when writing that control file. (Maybe because of the supplied pkgconf of libssh?)

In case you've got an Ubuntu system lying around, could you have a glimpse whether the build still works there? Otherwise I might also check this at a later time by myself.

Thanks again! :)

brenard commented 2 years ago

Hey there, thanks a lot for approaching me with this PR!

That makes perfect sense I guess, I will however need to make sure this does not break all Ubuntu-based distros or the build process for those platforms described in the README.

For now, it seems the name was already adopted into 18.04LTS (but still, their version is too old), so I don't really now why I sticked to this name when writing that control file. (Maybe because of the supplied pkgconf of libssh?)

In case you've got an Ubuntu system lying around, could you have a glimpse whether the build still works there? Otherwise I might also check this at a later time by myself.

My change only allow an alternative package for libssh and dpkg / apt process will be satisfied with libssh-4 package if available instead of regular libssh package. It's a common way to handle alternative dependency between multiple distros (or distro version). So, I think it will not affected other distros. But, it's never a bad idea to test and retest ! I try the docker-based build process using the ubuntu docker image and it work great and the resulting deb file installs correctly on my Debian Bullseye. I didn't have Ubuntu host to test an installation, but I also test on a Debian old-stable (Buster) and it's OK.

pentix commented 2 years ago

Nice, thank you! It builds here as well!

Thanks for the contribution and checking it! :relaxed: