pento / testpress

Tool for helping you get a WordPress Core test environment up and running.
GNU General Public License v2.0
68 stars 2 forks source link

Translucent bar appears above TestPress #120

Closed noisysocks closed 5 years ago

noisysocks commented 5 years ago

A very subtle translucent bar appears between the TestPress window and the menu bar. Looks odd.

ready
noisysocks commented 5 years ago

I'm thinking this happens because of the border radius that Electron applies to the BrowserWindow. It doesn't look like this can be disabled (https://github.com/electron/electron/issues/414), so my inclination is to ditch the tray pointer in TestPress altogether.

pento commented 5 years ago

This is actually a bug in MacOS.

pento commented 5 years ago

While there's no timeline for when this bug might be fixed in MacOS, I'm leaning towards just waiting it out. Putting the window right up against the tray is how tray menus looks, so it feels kind of weird for it to not be a menu in that case.

@karmatosed: Do you have thoughts on this?

karmatosed commented 5 years ago

It's hard to tell but I think Evernote also suffers from this?

2019-04-01 at 09 18

I would say stay with the issue if a bug that's not ours. As it's not a menu treating it how Evernote and other 'interaction apps' do is better.

pento commented 5 years ago

Cool, thanks for your feedback, @karmatosed!