search

pento / testpress

Tool for helping you get a WordPress Core test environment up and running.
GNU General Public License v2.0
68 stars 2 forks source link

Fix nginx's redirect config. #128

Closed pento closed 5 years ago

pento commented 5 years ago

Fixes https://github.com/pento/testpress/issues/106.

Turning off the absolute_redirect directive changes redirects to be relative, so the port won't be removed from the URL.

This method also allows the port that Docker is listening on to be changed without needing to alter the nginx config.

pento commented 5 years ago

What happens if you do this?

As this is an nginx config change, the nginx container needs to restart to see it. #129 will fix this issue.

pento commented 5 years ago

I've rebased this PR, so that it includes the fix from #129.

pento commented 5 years ago

@noisysocks does this PR fix the problem for you now? I don't know if you retested after #129 was merged.

noisysocks commented 5 years ago

When I test this it doesn't look like TestPress is properly running wp core install as navigating to /wp-admin asks me to select a language.

Still, I am not seeing the redirect issue anymore, and the above happens for me on master, so :shipit:!