pento / testpress

Tool for helping you get a WordPress Core test environment up and running.
GNU General Public License v2.0
68 stars 2 forks source link

Use the check-licenses script #137

Closed pento closed 5 years ago

pento commented 5 years ago

We should automatically check licenses on PRs.

Running check-licenses on the repo finds a couple of issues:

$ npx wp-scripts check-licenses --dev
 ERROR  Module xmldom has an incompatible license 'LGPL'.
$ npx wp-scripts check-licenses --prod --gpl2
 ERROR  Module detect-libc has an incompatible license 'Apache-2.0'.

xmldom is an easy fix, we just need to add LGPL to @wordpress/wp-scripts.

detect-libc is a little trickier, as it's ultimately included by chokidar, which we do use. nsfw is an interesting alternative to chokidar, it's also used by VS Code.