search

pentoo / pentoo-installer

Pentoo installer rewritten by Wuodan to be more modular
10 stars 6 forks source link

feature: Unsafe skip verify #58

Closed brianredbeard closed 4 years ago

brianredbeard commented 4 years ago

This adds a flag for --unsafe-skip-verify allowing users who have not booted with the verify option to skip this while forcing them to acknowledge the inherant concerns with skipping digest checking of resources.

Additionally, this adds the variable INSTALLER_UNSAFE which allows for determining if the verification step has been skipped.

ZeroChaos- commented 4 years ago

How many times do you have to install Pentoo that you need to do this? Also of note, I don't think there is any number here which would make me want to disable this check personally. That's why it happens by default at boot and against during the installer if you bypassed it at boot. The corruption this detects is the number one cause of unreplicatable bug reports.

brianredbeard commented 4 years ago

In that case, the verification checks need to be restructured so that they are not assuming static paths (e.g. /mnt/cdrom) and can be based on a separately introspected value.

ZeroChaos- commented 4 years ago

The boot time verification checks don't work either? Or you are just skipping them because they are slow? honestly if the boot time verification doesn't work I don't know how the cd is booting at all in your configuration.

ZeroChaos- commented 4 years ago

the spirit and intent of being able to run the installer while not actually booted into pentoo was addressed by adding a script to the iso https://github.com/pentoo/pentoo-livecd/blob/master/livecd/isoroot/live_chroot.sh

Disabling verify because it's broken will just reveal tons of breakage behind that point if things aren't mounted where expected, so the script mounts things like initramfs does and lets the user install like that.... which is crazy but does actually work.