penumbra-zone / decaf377

decaf377 is a prime-order group designed for use in SNARKs over BLS12-377
https://protocol.penumbra.zone/main/crypto/decaf377.html
12 stars 12 forks source link

Make raw constructors of field elements private #90

Closed cronokirby closed 5 months ago

cronokirby commented 5 months ago

The rationale here is that we only want the existing methods of constructing field elements, including from bytes.

There's an argument in favor of adding a constructor which takes in 64 bit limbs and reduces mod order, but that doesn't strike me as particularly necessary.