search

penumbra-zone / dex-explorer

Web app for visualization the state of the Penumbra DEX
Apache License 2.0
10 stars 1 forks source link

Merge candle logic update #151

Open grod220 opened 2 days ago

grod220 commented 2 days ago

@cronokirby to update pindexer to handle candlestick merging. The API route can remove all merge logic and rely on the single-direction query from the database.

Secondly, the backend should pass base-denominated values back to the frontend who is responsible for doing the base->display conversions.

cronokirby commented 2 days ago

I think on the dex explorer side the change should just be to only make one database query, and pindexer itself should worry about making the chart have both pieces of information. On the dex ex side we should just need the frontend to fill in empty candles (on the frontend, to not transfer that data)

grod220 commented 2 days ago

Ah, in that case, will revise the description and please ping this issue when the merging can be removed from the API please 🙏