penumbra-zone / dex-explorer

Web app for visualization the state of the Penumbra DEX
Apache License 2.0
10 stars 1 forks source link

Dynamic client side envs #79

Closed JasonMHasperhoven closed 1 month ago

JasonMHasperhoven commented 1 month ago

As per @conorsch 's request, this adds support to set envs dynamically post-build.

JasonMHasperhoven commented 1 month ago

I'm still on the fence whether we should do this, @grod220 any thoughts?

grod220 commented 1 month ago

It's tough for me to review this with all the formatting changes. Could you open another PR that just does the formatting (and adds CI/CD checks for prettier)?

JasonMHasperhoven commented 1 month ago

It's tough for me to review this with all the formatting changes. Could you open another PR that just does the formatting (and adds CI/CD checks for prettier)?

I didn't wanna do it, but I did it: https://github.com/penumbra-zone/dex-explorer/pull/80

JasonMHasperhoven commented 1 month ago

Closing this one.

grod220 commented 1 month ago

I didn't wanna do it, but I did it: https://github.com/penumbra-zone/dex-explorer/pull/80

This isn't the formatting change PR though right? I think those changes are important and there should be a CI/CD test like in penumbra-zone/web.

grod220 commented 1 month ago

If we merged that separately, this PR would have automatically been cleared up