penumbra-zone / galileo

Discord bot for the Penumbra discord
2 stars 5 forks source link

build: pare down vendored proto definitions #102

Open conorsch opened 4 months ago

conorsch commented 4 months ago

As of https://github.com/penumbra-zone/galileo/pull/99, we're using vendored proto definitions from the Penumbra monorepo. The initial inclusion of proto defs copied them over from the Penumbra repo. Instead, we should be using the buf-tooling to fetch the info that we need. We also don't need all those protos, like tendermint, ibc, etc. It should be enough to fetch-and-then-vendor only the specific proto defs that we need.

One way to do this is to fetch via buf export and then rm -rf <dir> and dirs we don't care about. See similar logic in:

We could also wire up CI to publish the Galileo protos, but I don't think that's necessary, and would prefer to avoid it until it's must-do for some reason.

cratelyn commented 4 months ago

thank you for filing this! i'd love to avoid the need to vendor these, i appreciate your grace in allowing me to be expeditious and hacky 🙏