penumbra-zone / penumbra

Penumbra is a fully private proof-of-stake network and decentralized exchange for the Cosmos ecosystem.
https://penumbra.zone
Apache License 2.0
381 stars 296 forks source link

add tests for double voting #2927

Open redshiftzero opened 1 year ago

redshiftzero commented 1 year ago

We lack tests:

These are currently hard to write (related to https://github.com/penumbra-zone/penumbra/issues/2754 and https://github.com/penumbra-zone/penumbra/issues/2771). We can't setup the preconditions needed to write the tests for the delegator vote: if we use the existing MockClient-style tests (as added for the duplicate nullifier tests for spends mentioned above), when we try to get the IdentityKey for a validator in order to delegate, there are no validators (because there is no Tendermint), so we can't stake a note. Without a staked note, we can't form a delegator vote.

hdevalence commented 9 months ago

Blocked by lack of integration test support. We should not add this to the smoke tests.