penumbra-zone / penumbra

Penumbra is a fully private proof-of-stake network and decentralized exchange for the Cosmos ecosystem.
https://penumbra.zone
Apache License 2.0
382 stars 296 forks source link

pcli: `validator-governance-subkey` subcommand is in the wrong place #4214

Open hdevalence opened 7 months ago

hdevalence commented 7 months ago

Describe the bug

Running pcli init --help describes a validator-governance-subkey command that's only relevant for validators. We already have a place for commands that are only relevant for validators, namely pcli validator, and it should move there.

Prospective contributors: hit up @erwanor here or on Discord if you want to pick this up!

kerber0x commented 6 months ago

Would like to help with this one @erwanor

erwanor commented 6 months ago

Sounds great, thanks! do you have any questions? @kerber0x feel free to open a draft pr early and we can workshop it as we go

erwanor commented 6 months ago

This is a bit more squirrelly than anticipated, removed the good-first-issue tag. I will update the issue with a plan at a later time. Apologies for the churn @kerber0x