search

penumbra-zone / penumbra

Penumbra is a fully private proof-of-stake network and decentralized exchange for the Cosmos ecosystem.
https://penumbra.zone
Apache License 2.0
376 stars 294 forks source link

pcli should not depend on rocksdb #4534

Open hdevalence opened 4 months ago

hdevalence commented 4 months ago

Describe the bug

Two compounding errors during development led to pcli depending on all of rocksdb:

  1. pcli imports the entire app crate in order to run stateless checks before submitting the transaction; this was originally intended for debugging and is not necessary.
  2. The app crate is not split, like the other penumbra crates, into a component feature that gates all of the component logic behind a feature flag, allowing access to its data structures without the logic.

This causes problems for users trying to use pcli in high-security contexts that don't have glibc.

cratelyn commented 4 months ago

:raising_hand_woman: i would like to tentatively sign up for this, pending refinement. cc: @aubrika

hdevalence commented 3 months ago

Re-prioritizing to low since the users in question found a workaround.