search

penumbra-zone / tower-abci

Tower-based ABCI interface.
MIT License
75 stars 24 forks source link

refactor(server): concise `Server` constructor #16

Closed erwanor closed 1 year ago

erwanor commented 2 years ago

This is kind of a nitpick, but keeping the ServerBuilder logic concise does makes it a little easier to focus on the rest of the codebase imo!

erwanor commented 2 years ago

Mmh weird, it does not compile because of a prost version mismatch (fails with 0.9, works with 0.10). ButCargo.toml correctly refers to tendermint-proto on tag v0.24.0-pre.1 which uses 0.9. When I go to definition of tendermint_proto::abci::Request, it takes me to the crate with version v0.24.0-pre.2 which indeed uses 0.10. Weird!