penumbra-zone / tower-abci

Tower-based ABCI interface.
MIT License
75 stars 24 forks source link

tower-abci: add support for gRPC #31

Open erwanor opened 1 year ago

erwanor commented 1 year ago

What's the downside to adding gRPC support to tower-abci?

We could have a second Server implementation that translates Tonic-generated types into domain types and invokes the inner tower::Services, and wouldn't need to jump through the hoops the TSP server does to translate into requests/responses.

We wouldn't have to wait on any upstream, and it would give us optionality to migrate to grpc communication with no significant changes to pd.

Originally posted by @hdevalence in https://github.com/penumbra-zone/penumbra/issues/2771#issuecomment-1646662201

This is currently blocked on merging https://github.com/informalsystems/tendermint-rs/pull/1338/files into tendermint-rs, #30 , and upgrading to tendermint-rs@0.34 when it is released.