search

penumbra-zone / web

Apache License 2.0
10 stars 12 forks source link

buildtime or runtime configurable endpoint in node-status #1062

Open turbocrime opened 2 months ago

turbocrime commented 2 months ago

https://github.com/penumbra-zone/web/blob/b97e2102767369a835e4fc6b1df49ce0ab30f9f3/apps/node-status/src/constants.ts#L1-L5

https://github.com/penumbra-zone/web/blob/b97e2102767369a835e4fc6b1df49ce0ab30f9f3/apps/node-status/src/clients/grpc.ts#L1-L10

couple approaches.

  1. use env vars at build time, like prax
  2. use env vars at runtime
  3. use config file at runtime
  4. use command-line args at runtime

should probably use same name env vars as prax

hdevalence commented 2 months ago

should probably use same name env vars as minifront

Ignorant question but why does minifront have env vars for an endpoint? Shouldn't it just talk to prax?

turbocrime commented 2 months ago

i misspoke, prax has the vars. minifront does not

turbocrime commented 2 months ago

ah, prax also no longer has a var? lol

https://github.com/penumbra-zone/web/blob/b97e2102767369a835e4fc6b1df49ce0ab30f9f3/apps/extension/.env.testnet#L1-L4

turbocrime commented 2 months ago

i think this is not quite an 'rpc' issue, as the client's configured endpoint shouldn't be available via rpc