search

penumbra-zone / web

Apache License 2.0
12 stars 14 forks source link

Upstream Cuiloa getters #1182

Open grod220 opened 2 months ago

grod220 commented 2 months ago

Getters have been a canonical way for the web repo to "get" a deeply nested value from a proto class with optional fields. So far it's worked well and has been adopted outside of the repo by other code bases, namely Cuiloa.

In Cuiloa, there has been a substantial build up of proto Getters. This has been quite useful for that repo, but we should upstream this to the Getter package so it can be shared globally.

Let's be mindful in keeping the current organization scheme though.

ejmg commented 2 months ago

I'll shoot off an outline PR with my best attempt/interpretation of the current existing approach to grabbing schema values and we can go from there? As I've mentioned myself, there was a change in approach midway through my own rollout after getting a feel for how extracting data and using it within components worked out but I ultimately don't know how universal that is.