penumbra-zone / web

Apache License 2.0
10 stars 7 forks source link

Return a TxInfo struct [#1255 follow up] #1261

Closed grod220 closed 3 weeks ago

grod220 commented 3 weeks ago

Defining a wasm-bindgen struct allows for a simpler return value while keeping the same type signature.

Follow up from: https://github.com/penumbra-zone/web/pull/1255#pullrequestreview-2101210513

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 810622d508a962b07b45d572ddb6229f4c5716b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages | Name | Type | | ------------------------------- | ----- | | @penumbra-zone/wasm | Patch | | chrome-extension | Patch | | @penumbra-zone/perspective | Patch | | @penumbra-zone/query | Patch | | @penumbra-zone/services-context | Patch | | @penumbra-zone/services | Patch | | minifront | Patch | | @penumbra-zone/ui | Patch | | node-status | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

turbocrime commented 3 weeks ago

thanks

turbocrime commented 3 weeks ago

however we probably shouldn't call it "txinfo" as it's too similar to the actual transactioninfo type that we have